Skip to content

Support inheriting namespace through portals#4993

Merged
JoviDeCroock merged 1 commit intov10.xfrom
support-namespace-inheritance
Jan 9, 2026
Merged

Support inheriting namespace through portals#4993
JoviDeCroock merged 1 commit intov10.xfrom
support-namespace-inheritance

Conversation

@JoviDeCroock
Copy link
Member

@JoviDeCroock JoviDeCroock commented Jan 8, 2026

Resolves #4992

@github-actions
Copy link

github-actions bot commented Jan 8, 2026 •
edited
Loading

📊 Tachometer Benchmark Results

Summary

duration

  • create10k: unsure 🔍 -0% - +1% (-1.29ms - +7.58ms)
    preact-local vs preact-main
  • filter-list: unsure 🔍 -0% - +1% (-0.01ms - +0.08ms)
    preact-local vs preact-main
  • hydrate1k: unsure 🔍 -2% - +1% (-1.30ms - +0.54ms)
    preact-local vs preact-main
  • many-updates: unsure 🔍 -2% - +2% (-0.41ms - +0.38ms)
    preact-local vs preact-main
  • replace1k: unsure 🔍 -3% - +0% (-1.63ms - +0.03ms)
    preact-local vs preact-main
  • text-update: unsure 🔍 -1% - +5% (-0.03ms - +0.10ms)
    preact-local vs preact-main
  • todo: unsure 🔍 -1% - +1% (-0.19ms - +0.41ms)
    preact-local vs preact-main
  • update10th1k: unsure 🔍 -3% - +4% (-0.82ms - +1.26ms)
    preact-local vs preact-main

usedJSHeapSize

  • create10k: unsure 🔍 -0% - +0% (-0.01ms - +0.02ms)
    preact-local vs preact-main
  • filter-list: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-main
  • hydrate1k: unsure 🔍 -6% - +6% (-0.35ms - +0.36ms)
    preact-local vs preact-main
  • many-updates: unsure 🔍 -0% - +0% (-0.00ms - +0.01ms)
    preact-local vs preact-main
  • replace1k: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-main
  • text-update: unsure 🔍 -3% - +5% (-0.03ms - +0.05ms)
    preact-local vs preact-main
  • todo: unsure 🔍 -2% - +1% (-0.02ms - +0.01ms)
    preact-local vs preact-main
  • update10th1k: unsure 🔍 -0% - +1% (-0.01ms - +0.02ms)
    preact-local vs preact-main

Results

create10k

duration

VersionAvg timevs preact-localvs preact-main
preact-local879.14ms - 886.40ms-unsure 🔍
-0% - +1%
-1.29ms - +7.58ms
preact-main877.08ms - 882.17msunsure 🔍
-1% - +0%
-7.58ms - +1.29ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local19.19ms - 19.22ms-unsure 🔍
-0% - +0%
-0.01ms - +0.02ms
preact-main19.19ms - 19.20msunsure 🔍
-0% - +0%
-0.02ms - +0.01ms		-
filter-list

duration

VersionAvg timevs preact-localvs preact-main
preact-local16.57ms - 16.65ms-unsure 🔍
-0% - +1%
-0.01ms - +0.08ms
preact-main16.55ms - 16.60msunsure 🔍
-0% - +0%
-0.08ms - +0.01ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local1.56ms - 1.56ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms
preact-main1.56ms - 1.56msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms		-
hydrate1k

duration

VersionAvg timevs preact-localvs preact-main
preact-local61.20ms - 62.41ms-unsure 🔍
-2% - +1%
-1.30ms - +0.54ms
preact-main61.50ms - 62.88msunsure 🔍
-1% - +2%
-0.54ms - +1.30ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local5.67ms - 6.17ms-unsure 🔍
-6% - +6%
-0.35ms - +0.36ms
preact-main5.67ms - 6.16msunsure 🔍
-6% - +6%
-0.36ms - +0.35ms		-
many-updates

duration

VersionAvg timevs preact-localvs preact-main
preact-local16.20ms - 16.80ms-unsure 🔍
-2% - +2%
-0.41ms - +0.38ms
preact-main16.25ms - 16.78msunsure 🔍
-2% - +2%
-0.38ms - +0.41ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local3.72ms - 3.73ms-unsure 🔍
-0% - +0%
-0.00ms - +0.01ms
preact-main3.72ms - 3.72msunsure 🔍
-0% - +0%
-0.01ms - +0.00ms		-
replace1k
  • Browser: chrome-headless
  • Sample size: 100
  • Built by: CI #5279

  • Commit: 396d669

duration

VersionAvg timevs preact-localvs preact-main
preact-local56.73ms - 57.90ms-unsure 🔍
-3% - +0%
-1.63ms - +0.03ms
preact-main57.52ms - 58.71msunsure 🔍
-0% - +3%
-0.03ms - +1.63ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local3.00ms - 3.00ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms
preact-main3.00ms - 3.00msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms		-

run-warmup-0

VersionAvg timevs preact-localvs preact-main
preact-local25.73ms - 26.41ms-unsure 🔍
-2% - +2%
-0.58ms - +0.44ms
preact-main25.77ms - 26.52msunsure 🔍
-2% - +2%
-0.44ms - +0.58ms		-

run-warmup-1

VersionAvg timevs preact-localvs preact-main
preact-local32.10ms - 33.37ms-unsure 🔍
-0% - +5%
-0.12ms - +1.67ms
preact-main31.34ms - 32.59msunsure 🔍
-5% - +0%
-1.67ms - +0.12ms		-

run-warmup-2

VersionAvg timevs preact-localvs preact-main
preact-local30.81ms - 31.94ms-unsure 🔍
-3% - +1%
-1.09ms - +0.46ms
preact-main31.15ms - 32.21msunsure 🔍
-1% - +3%
-0.46ms - +1.09ms		-

run-warmup-3

VersionAvg timevs preact-localvs preact-main
preact-local25.43ms - 25.85ms-unsure 🔍
-2% - +1%
-0.46ms - +0.17ms
preact-main25.54ms - 26.02msunsure 🔍
-1% - +2%
-0.17ms - +0.46ms		-

run-warmup-4

VersionAvg timevs preact-localvs preact-main
preact-local23.56ms - 24.66ms-faster ✔
1% - 7%
0.18ms - 1.81ms
preact-main24.50ms - 25.70msslower ❌
1% - 8%
0.18ms - 1.81ms		-

run-final

VersionAvg timevs preact-localvs preact-main
preact-local21.30ms - 21.80ms-unsure 🔍
-2% - +1%
-0.45ms - +0.21ms
preact-main21.45ms - 21.89msunsure 🔍
-1% - +2%
-0.21ms - +0.45ms		-
text-update
  • Browser: chrome-headless
  • Sample size: 240
  • Built by: CI #5279

  • Commit: 396d669

duration

VersionAvg timevs preact-localvs preact-main
preact-local1.81ms - 1.90ms-unsure 🔍
-1% - +5%
-0.03ms - +0.10ms
preact-main1.77ms - 1.86msunsure 🔍
-5% - +1%
-0.10ms - +0.03ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local1.03ms - 1.10ms-unsure 🔍
-3% - +5%
-0.03ms - +0.05ms
preact-main1.03ms - 1.08msunsure 🔍
-5% - +3%
-0.05ms - +0.03ms		-
todo

duration

VersionAvg timevs preact-localvs preact-main
preact-local33.66ms - 34.04ms-unsure 🔍
-1% - +1%
-0.19ms - +0.41ms
preact-main33.52ms - 33.97msunsure 🔍
-1% - +1%
-0.41ms - +0.19ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local1.26ms - 1.28ms-unsure 🔍
-2% - +1%
-0.02ms - +0.01ms
preact-main1.26ms - 1.29msunsure 🔍
-1% - +2%
-0.01ms - +0.02ms		-
update10th1k

duration

VersionAvg timevs preact-localvs preact-main
preact-local30.45ms - 31.95ms-unsure 🔍
-3% - +4%
-0.82ms - +1.26ms
preact-main30.26ms - 31.70msunsure 🔍
-4% - +3%
-1.26ms - +0.82ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local2.97ms - 2.99ms-unsure 🔍
-0% - +1%
-0.01ms - +0.02ms
preact-main2.97ms - 2.98msunsure 🔍
-1% - +0%
-0.02ms - +0.01ms		-

tachometer-reporter-action v2 for CI

@github-actions
Copy link

github-actions bot commented Jan 8, 2026

Size Change: +56 B (+0.07%)

Total Size: 79.2 kB

Filename Size Change
compat/dist/compat.js 4.18 kB +14 B (+0.34%)
compat/dist/compat.mjs 4.11 kB +14 B (+0.34%)
compat/dist/compat.module.js 4.11 kB +14 B (+0.34%)
compat/dist/compat.umd.js 4.25 kB +14 B (+0.33%)
ℹ️ View Unchanged
Filename Size
debug/dist/debug.js 3.85 kB
debug/dist/debug.mjs 3.85 kB
debug/dist/debug.module.js 3.85 kB
debug/dist/debug.umd.js 3.93 kB
devtools/dist/devtools.js 260 B
devtools/dist/devtools.mjs 274 B
devtools/dist/devtools.module.js 274 B
devtools/dist/devtools.umd.js 346 B
dist/preact.js 4.78 kB
dist/preact.min.js 4.8 kB
dist/preact.min.module.js 4.8 kB
dist/preact.min.umd.js 4.82 kB
dist/preact.mjs 4.79 kB
dist/preact.module.js 4.79 kB
dist/preact.umd.js 4.83 kB
hooks/dist/hooks.js 1.54 kB
hooks/dist/hooks.mjs 1.57 kB
hooks/dist/hooks.module.js 1.57 kB
hooks/dist/hooks.umd.js 1.61 kB
jsx-runtime/dist/jsxRuntime.js 1.01 kB
jsx-runtime/dist/jsxRuntime.mjs 985 B
jsx-runtime/dist/jsxRuntime.module.js 985 B
jsx-runtime/dist/jsxRuntime.umd.js 1.08 kB
test-utils/dist/testUtils.js 473 B
test-utils/dist/testUtils.mjs 477 B
test-utils/dist/testUtils.module.js 477 B
test-utils/dist/testUtils.umd.js 555 B

compressed-size-action

ckifer
ckifer approved these changes Jan 8, 2026
View reviewed changes
Copy link

@ckifer ckifer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the quick fix!

@JoviDeCroock JoviDeCroock merged commit 4317858 into v10.x Jan 9, 2026
14 checks passed
@JoviDeCroock JoviDeCroock deleted the support-namespace-inheritance branch January 9, 2026 06:29
JoviDeCroock added a commit that referenced this pull request Jan 9, 2026
@JoviDeCroock
Support inheriting namespace through portals (#4993)
bc34a4b
JoviDeCroock added a commit that referenced this pull request Jan 9, 2026
@JoviDeCroock
Support inheriting namespace through portals (#4993) (#4995)
46772a2
This was referenced Jan 31, 2026
Merged
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@marvinhagemeister marvinhagemeister marvinhagemeister approved these changes

@rschristian rschristian rschristian approved these changes

+1 more reviewer

@ckifer ckifer ckifer approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@JoviDeCroock @marvinhagemeister @ckifer @rschristian